use dmabuf option when the ibperf binaries have them configured#235
Open
ahskabir wants to merge 1 commit into
Open
use dmabuf option when the ibperf binaries have them configured#235ahskabir wants to merge 1 commit into
ahskabir wants to merge 1 commit into
Conversation
Signed-off-by: Ahsan Kabir <Ahsan.Kabir@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
IBPERF test makes use of the binaries for which path is provided in the configuration file. It also has an option to install the
ibperftool and then to run the test. But during the run-time when it prepares theibperfinvocation command(s) it doesn't use the--use_rocm_dmabufoption and the run could be less performant.Technical Details
A function is added in the ibperf library. This function check to see whether the ibperf binary was configured with --use_rocm_dmabuf. If yes, it will use the flag for invocation, otherwise not.
Test Plan
All ibperf test was run using ibperf binaries configured with --use_rocm_dmabuf and test passed.
All ibperf test was run using ibperf binaries not configured with --use_rocm_dmabuf and test passed.
Test Result
In both the scenarios, all tests passed.
Submission Checklist